Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 40C7C200BFA for ; Thu, 29 Dec 2016 06:32:00 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 3F65A160B35; Thu, 29 Dec 2016 05:32:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id AEB2D160B2E for ; Thu, 29 Dec 2016 06:31:59 +0100 (CET) Received: (qmail 95316 invoked by uid 500); 29 Dec 2016 05:31:58 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 95304 invoked by uid 99); 29 Dec 2016 05:31:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 29 Dec 2016 05:31:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 703F02C0453 for ; Thu, 29 Dec 2016 05:31:58 +0000 (UTC) Date: Thu, 29 Dec 2016 05:31:58 +0000 (UTC) From: "David Smiley (JIRA)" To: dev@lucene.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (SOLR-9902) StandardDirectoryFactory should use Files API for it's move implementation. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 29 Dec 2016 05:32:00 -0000 [ https://issues.apache.org/jira/browse/SOLR-9902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15784562#comment-15784562 ] David Smiley commented on SOLR-9902: ------------------------------------ Why does your patch do this: {code}FileSystems.getDefault().getPath(path1.toString(), fileName){code} Instead of simply: {code}path1.resolve(fileName){code} > StandardDirectoryFactory should use Files API for it's move implementation. > --------------------------------------------------------------------------- > > Key: SOLR-9902 > URL: https://issues.apache.org/jira/browse/SOLR-9902 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Reporter: Mark Miller > Assignee: Mark Miller > Fix For: master (7.0), 6.4 > > Attachments: SOLR-9902.patch > > > It's done in a platform independent way as opposed to the old File API. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org