Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@lucene.apache.org
Date: Thu, 8 Dec 2016 20:36:58 +0000 (UTC)
From: "Steve Rowe (JIRA)" <jira@apache.org>
To: dev@lucene.apache.org
Message-ID: <JIRA.13026585.1481179367000.476726.1481229418396@Atlassian.JIRA>
In-Reply-To: <JIRA.13026585.1481179367000@Atlassian.JIRA>
References: <JIRA.13026585.1481179367000@Atlassian.JIRA> <JIRA.13026585.1481179367846@arcas>
Subject: [jira] [Commented] (LUCENE-7585) Interface for common parameters
 used across analysis factories
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 08 Dec 2016 20:37:00 -0000


    [ https://issues.apache.org/jira/browse/LUCENE-7585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15733334#comment-15733334 ] 

Steve Rowe commented on LUCENE-7585:
------------------------------------

The patch appears to be against a non-existent version of {{CommonAnalysisFactoryParams.java}}, so doesn't apply properly.  Manual repair worked for me (saving the patch as the target file, trimming to include just the target file contents, removing {{-}} lines, and deleting {{+}} prefixes from lines).

It'd be nice to alphabetize the constants.

Otherwise, +1.

> Interface for common parameters used across analysis factories
> --------------------------------------------------------------
>
>                 Key: LUCENE-7585
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7585
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/analysis
>    Affects Versions: 6.3
>            Reporter: Ahmet Arslan
>            Assignee: David Smiley
>            Priority: Minor
>             Fix For: master (7.0)
>
>         Attachments: LUCENE-7585.patch
>
>
> Certain parameters (String constants) are same/common for multiple analysis factories. Some examples are {{ignoreCase}}, {{dictionary}}, and {{preserveOriginal}}. These string constants are handled inconsistently in different factories. This is an effort to define most common constants in ({{CommonAnalysisFactoryParams}}) interface and reuse them.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org