lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Smiley (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-9902) StandardDirectoryFactory should use Files API for it's move implementation.
Date Thu, 29 Dec 2016 05:31:58 GMT

    [ https://issues.apache.org/jira/browse/SOLR-9902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15784562#comment-15784562
] 

David Smiley commented on SOLR-9902:
------------------------------------

Why does your patch do this:
{code}FileSystems.getDefault().getPath(path1.toString(), fileName){code}
Instead of simply:
{code}path1.resolve(fileName){code}

> StandardDirectoryFactory should use Files API for it's move implementation.
> ---------------------------------------------------------------------------
>
>                 Key: SOLR-9902
>                 URL: https://issues.apache.org/jira/browse/SOLR-9902
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>             Fix For: master (7.0), 6.4
>
>         Attachments: SOLR-9902.patch
>
>
> It's done in a platform independent way as opposed to the old File API.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message