lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan Woodward (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-9869) MiniSolrCloudCluster does not always remove jettys from running list after stopping them
Date Tue, 20 Dec 2016 19:21:58 GMT

    [ https://issues.apache.org/jira/browse/SOLR-9869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15765014#comment-15765014
] 

Alan Woodward commented on SOLR-9869:
-------------------------------------

IIRC it's to avoid ConcurrentModificationExceptions during parallel shutdown, but we can avoid
that I think by just calling jetty.stop() directly in the shutdown() lambdas rather than calling
the stop method.

> MiniSolrCloudCluster does not always remove jettys from running list after stopping them
> ----------------------------------------------------------------------------------------
>
>                 Key: SOLR-9869
>                 URL: https://issues.apache.org/jira/browse/SOLR-9869
>             Project: Solr
>          Issue Type: Test
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: Tests
>            Reporter: Mike Drob
>         Attachments: SOLR-9869.patch
>
>
> MiniSolrCloudCluster has two {{stopJettySolrRunner}} methods that behave differently.
> The {{int}} version calls {{jettys.remove(index);}} to remove the now stopped jetty from
the list of running jettys.
> The version that takes a {{JettySolrRunner}}, however, does not modify the running list.
> This can cause calls to {{getReplicaJetty}} to fail after a call to {{stop}} because
we will try to get the base url of a stopped jetty.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message