lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-7564) AnalyzingInfixSuggester should close its IndexWriter by default at the end of build()
Date Thu, 29 Dec 2016 21:13:58 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-7564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15786146#comment-15786146
] 

ASF subversion and git services commented on LUCENE-7564:
---------------------------------------------------------

Commit 73f068e50333902b3ea887100f063e61ebf1996b in lucene-solr's branch refs/heads/branch_6x
from [~steve_rowe]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=73f068e ]

LUCENE-7564: Force single-threaded access to the AnalyzingInfixSuggester's SearcherManager
when performing an acquire() or reassigning.  This fixes failures in AnalyzingInfixSuggester.testRandomNRT().


> AnalyzingInfixSuggester should close its IndexWriter by default at the end of build()
> -------------------------------------------------------------------------------------
>
>                 Key: LUCENE-7564
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7564
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Steve Rowe
>            Assignee: Steve Rowe
>             Fix For: master (7.0), 6.4
>
>         Attachments: LUCENE-7564-fix-random-NRT-failures.patch, LUCENE-7564-fix-random-NRT-failures.patch,
LUCENE-7564.patch, LUCENE-7564.patch
>
>
> From SOLR-6246, where AnalyzingInfixSuggester's write lock on its index is causing trouble
when reloading a Solr core:
> [~gsingers] wrote:
> bq. One suggestion that might minimize the impact: close the writer after build
> [~varunthacker] wrote:
> {quote}
> This is what I am thinking -
> Create a Lucene issue in which {{AnalyzingInfixSuggester#build}} closes the writer by
default at the end.
> The {{add}} and {{update}} methods call {{ensureOpen}} and those who do frequent real
time updates directly via lucene won't see any slowdowns.
> [~mikemccand] - Would this approach have any major drawback from Lucene's perspective?
Else I can go ahead an tackle this in a Lucene issue
> {quote}
> [~mikemccand] wrote:
> bq. Fixing {{AnalyzingInfixSuggester}} to close the writer at the end of build seems
reasonable?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message