lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yonik Seeley (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-9712) Saner default for maxWarmingSearchers
Date Thu, 15 Dec 2016 18:33:58 GMT

    [ https://issues.apache.org/jira/browse/SOLR-9712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15752122#comment-15752122
] 

Yonik Seeley commented on SOLR-9712:
------------------------------------

Here's an updated patch that changes the default maxWarmingSearchers to 1.
It looks like I didn't need to create any additional tests... by changing maxWarmingSearchers
to 1 first, a bunch of the stress tests started failing since they also test concurrent commits.
 TestStressVersions, TestStressReorder, and TestRealTimeGet all failed (not an exhausted list
tested by hand) w/o the blocking patch and succeeded with it.

Unfortunately, running the full test suite results in some errors.  Not sure what's going
on there yet.

> Saner default for maxWarmingSearchers
> -------------------------------------
>
>                 Key: SOLR-9712
>                 URL: https://issues.apache.org/jira/browse/SOLR-9712
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: search
>            Reporter: Shalin Shekhar Mangar
>             Fix For: master (7.0), 6.4
>
>         Attachments: SOLR-9712.patch
>
>
> As noted in SOLR-9710, the default for maxWarmingSearchers is Integer.MAX_VALUE which
is just crazy. Let's have a saner default. Today we log a performance warning when the number
of on deck searchers goes over 1. What if we had the default as 1 that expert users can increase
if needed?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message