lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-8959) TestMiniSolrCloudCluster.testSegmentTerminateEarly should be refactored into it's own SolrCloudTestCase subclass
Date Wed, 14 Dec 2016 20:22:58 GMT

    [ https://issues.apache.org/jira/browse/SOLR-8959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15749360#comment-15749360
] 

ASF subversion and git services commented on SOLR-8959:
-------------------------------------------------------

Commit 4c22659879c0e84963d7c9cf8568380956d8166a in lucene-solr's branch refs/heads/branch_6x
from Chris Hostetter
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=4c22659 ]

SOLR-8959: Refactored TestSegmentSorting out of TestMiniSolrCloudCluster

(cherry picked from commit 6525bb56f027655e5a01f028fa373305c0d01caa)

Conflicts:
	solr/CHANGES.txt


> TestMiniSolrCloudCluster.testSegmentTerminateEarly should be refactored into it's own
SolrCloudTestCase subclass
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-8959
>                 URL: https://issues.apache.org/jira/browse/SOLR-8959
>             Project: Solr
>          Issue Type: Test
>            Reporter: Hoss Man
>
> The functionality tested in testSegmentTerminateEarly (and the helper code in "SegmentTerminateEarlyTestState")
should really belong in it's own test class, which can subclass SolrCloudTestCase.
> (I suspect the only reason this wasn't done initially in SOLR-5730 is because maybe the
patch predates the creation of SolrCloudTestCase?)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message