lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan Woodward (JIRA)" <>
Subject [jira] [Resolved] (LUCENE-5325) Move ValueSource and FunctionValues under core/
Date Thu, 29 Dec 2016 20:29:58 GMT


Alan Woodward resolved LUCENE-5325.
       Resolution: Fixed
         Assignee: Alan Woodward
    Fix Version/s: 6.4
                   master (7.0)

I pushed the fix for 6.x and added a test there and on master.  Thanks for the reviews!  I'll
open up some follow-up issues now.

> Move ValueSource and FunctionValues under core/
> -----------------------------------------------
>                 Key: LUCENE-5325
>                 URL:
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/search
>            Reporter: Shai Erera
>            Assignee: Alan Woodward
>             Fix For: master (7.0), 6.4
>         Attachments: LUCENE-5325-6x-matchingbits.patch, LUCENE-5325-6x.patch, LUCENE-5325.patch,
LUCENE-5325.patch, LUCENE-5325.patch, LUCENE-5325.patch, LUCENE-5325.patch, LUCENE-5325.patch,
> Spinoff from LUCENE-5298: ValueSource and FunctionValues are abstract APIs which exist
under the queries/ module. That causes any module which wants to depend on these APIs (but
not necessarily on any of their actual implementations!), to depend on the queries/ module.
If we move these APIs under core/, we can eliminate these dependencies and add some mock impls
for testing purposes.
> Quoting Robert from LUCENE-5298:
> {quote}
> we should eliminate the suggest/ dependencies on expressions and queries, the expressions/
on queries, the grouping/ dependency on queries, the spatial/ dependency on queries, its a
> {quote}
> To add to that list, facet/ should not depend on queries too.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message