Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 7214E200BC7 for ; Fri, 25 Nov 2016 20:33:01 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 6F9C8160B22; Fri, 25 Nov 2016 19:33:01 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B8D1F160AFA for ; Fri, 25 Nov 2016 20:33:00 +0100 (CET) Received: (qmail 93780 invoked by uid 500); 25 Nov 2016 19:32:59 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 93751 invoked by uid 99); 25 Nov 2016 19:32:59 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 25 Nov 2016 19:32:59 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 7D1012C03DE for ; Fri, 25 Nov 2016 19:32:59 +0000 (UTC) Date: Fri, 25 Nov 2016 19:32:59 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: dev@lucene.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (SOLR-9433) SolrCore clean-up logic uses incorrect path to delete dataDir on failure to create a core MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 25 Nov 2016 19:33:01 -0000 [ https://issues.apache.org/jira/browse/SOLR-9433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15696538#comment-15696538 ] ASF subversion and git services commented on SOLR-9433: ------------------------------------------------------- Commit 2badb2b4d8d2900c5323870e24f3f2023c200b33 in lucene-solr's branch refs/heads/branch_6x from [~shalinmangar] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=2badb2b ] SOLR-9433: Ignore testDeleteInstanceDirAfterCreateFailure on windows (cherry picked from commit eded69b) > SolrCore clean-up logic uses incorrect path to delete dataDir on failure to create a core > ----------------------------------------------------------------------------------------- > > Key: SOLR-9433 > URL: https://issues.apache.org/jira/browse/SOLR-9433 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Affects Versions: 5.5.2 > Reporter: Evan Sayer > Assignee: Shalin Shekhar Mangar > Fix For: master (7.0), 6.4 > > Attachments: SOLR-9433.patch > > > When a core fails to be created for some reason (errant schema or solrconfig etc.), {{SolrCore.deleteUnloadedCore()}} is called from {{unload()}} in CoreContainer in order to clean-up the possibly left-over {{dataDir}} and {{instanceDir}}. The problem is that the CoreDescriptor passed to {{SolrCore.deleteUnloadedCore()}} will have its value for {{dataDir}} set to just "data/" unless an explicit {{dataDir}} was specified by the user in the request to create the core, leading to an attempt to delete simply {{"data/"}}, which presumably resolves to a non-existent directory under Solr's home directory or some such. > https://github.com/apache/lucene-solr/blob/branch_5_5/solr/core/src/java/org/apache/solr/core/CoreContainer.java#L974 > https://github.com/apache/lucene-solr/blob/branch_5_5/solr/core/src/java/org/apache/solr/core/SolrCore.java#L2537 -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org