lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-9746) Eclipse project broken due to duplicate package-info.java in LTR contrib
Date Fri, 11 Nov 2016 21:46:58 GMT

    [ https://issues.apache.org/jira/browse/SOLR-9746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15658266#comment-15658266
] 

Uwe Schindler commented on SOLR-9746:
-------------------------------------

Hi,

as said before, I would not share packages between JAR files. This is a problem when we make
the Lucene/Solr packages real Java 9 modules using module-info.java. Currently it is not a
problem because the legacy JAR files use the legacy Java 9 classloader (all in one). But once
they get modules every JAR files has its own classloader and the module system disallows to
*export* same package (private packages are fine).

So in short: We should avoid sharing packages and not add *new* ones! So the fix used here
is fine.

> Eclipse project broken due to duplicate package-info.java in LTR contrib
> ------------------------------------------------------------------------
>
>                 Key: SOLR-9746
>                 URL: https://issues.apache.org/jira/browse/SOLR-9746
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Ishan Chattopadhyaya
>            Assignee: Christine Poerschke
>            Priority: Minor
>
> The eclipse project generated through {{ant eclipse}} seems to be broken, since there
are errors complaining duplicate resources. The problem is that the following files have the
same package and class names:
> {code}
> ./solr/core/src/java/org/apache/solr/response/transform/package-info.java
> ./solr/contrib/ltr/src/java/org/apache/solr/response/transform/package-info.java
> ./solr/core/src/java/org/apache/solr/search/package-info.java
> ./solr/contrib/ltr/src/java/org/apache/solr/search/package-info.java
> {code}
> Not sure if the idea project is affected.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message