lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-9433) SolrCore clean-up logic uses incorrect path to delete dataDir on failure to create a core
Date Tue, 01 Nov 2016 09:04:58 GMT

    [ https://issues.apache.org/jira/browse/SOLR-9433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15624850#comment-15624850
] 

ASF subversion and git services commented on SOLR-9433:
-------------------------------------------------------

Commit da7ccd3eefc92943ac0cea5103c84530f77d67a4 in lucene-solr's branch refs/heads/branch_6x
from [~shalinmangar]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=da7ccd3 ]

SOLR-9433: SolrCore clean-up logic uses incorrect path to delete dataDir on failure to create
a core

(cherry picked from commit 5120816)


> SolrCore clean-up logic uses incorrect path to delete dataDir on failure to create a
core
> -----------------------------------------------------------------------------------------
>
>                 Key: SOLR-9433
>                 URL: https://issues.apache.org/jira/browse/SOLR-9433
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>    Affects Versions: 5.5.2
>            Reporter: Evan Sayer
>         Attachments: SOLR-9433.patch
>
>
> When a core fails to be created for some reason (errant schema or solrconfig etc.), {{SolrCore.deleteUnloadedCore()}}
is called from {{unload()}} in CoreContainer in order to clean-up the possibly left-over {{dataDir}}
and {{instanceDir}}.  The problem is that the CoreDescriptor passed to {{SolrCore.deleteUnloadedCore()}}
will have its value for {{dataDir}} set to just "data/" unless an explicit {{dataDir}} was
specified by the user in the request to create the core, leading to an attempt to delete simply
{{"data/"}}, which presumably resolves to a non-existent directory under Solr's home directory
or some such.
> https://github.com/apache/lucene-solr/blob/branch_5_5/solr/core/src/java/org/apache/solr/core/CoreContainer.java#L974
> https://github.com/apache/lucene-solr/blob/branch_5_5/solr/core/src/java/org/apache/solr/core/SolrCore.java#L2537



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message