Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@lucene.apache.org
Date: Sat, 29 Oct 2016 16:10:58 +0000 (UTC)
From: "Erick Erickson (JIRA)" <jira@apache.org>
To: dev@lucene.apache.org
Message-ID: <JIRA.13016359.1477757429000.126205.1477757458336@Atlassian.JIRA>
In-Reply-To: <JIRA.13016359.1477757429000@Atlassian.JIRA>
References: <JIRA.13016359.1477757429000@Atlassian.JIRA> <JIRA.13016359.1477757429703@arcas>
Subject: [jira] [Created] (SOLR-9701) NPE in export handler when "fl"
 parameter is omitted.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Sat, 29 Oct 2016 16:11:04 -0000

Erick Erickson created SOLR-9701:
------------------------------------

             Summary: NPE in export handler when "fl" parameter is omitted.
                 Key: SOLR-9701
                 URL: https://issues.apache.org/jira/browse/SOLR-9701
             Project: Solr
          Issue Type: Bug
      Security Level: Public (Default Security Level. Issues are Public)
    Affects Versions: trunk, 6.4
            Reporter: Erick Erickson
            Assignee: Erick Erickson
            Priority: Minor


This started when a user reported that if you do not specify any parameters for the export handler, you get an NPE. I tracked it down to not specifying an "fl" parameter.

But in general I rearranged the error reporting in SortingResponseWriter.write so that immediately upon detecting a problem, the exception gets written to the output stream and then return immediately rather than save it up for the end. Preliminary version of the patch attached; it fixes the immediate problem.

Still to see is if it breaks any tests since the first error detected will be returned to the user rather than the last. I'll fix any tests that are sensitive to this and check in sometime this weekend.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org