lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dsmiley <...@git.apache.org>
Subject [GitHub] lucene-solr pull request #105: LUCENE-7526 Improvements to UnifiedHighlighte...
Date Fri, 28 Oct 2016 20:57:50 GMT
Github user dsmiley commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/105#discussion_r85608645
  
    --- Diff: lucene/highlighter/src/test/org/apache/lucene/search/uhighlight/visibility/TestUnifiedHighlighterExtensibility.java
---
    @@ -79,7 +90,7 @@ public void testFieldOffsetStrategyExtensibility() {
       @Test
       public void testUnifiedHighlighterExtensibility() {
         final int maxLength = 1000;
    -    UnifiedHighlighter uh = new UnifiedHighlighter(null, new MockAnalyzer(random())){
    +    UnifiedHighlighter uh = new UnifiedHighlighter(null, new MockAnalyzer(new Random())){
    --- End diff --
    
    ? why not `random()` ?  This will likely fail precommit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message