Return-Path: <dev-return-258648-archive-asf-public=cust-asf.ponee.io@lucene.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id B5BAF200B81
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Tue, 13 Sep 2016 17:22:22 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id B477B160AD2; Tue, 13 Sep 2016 15:22:22 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 0B2C8160AAA
	for <archive-asf-public@cust-asf.ponee.io>; Tue, 13 Sep 2016 17:22:21 +0200 (CEST)
Received: (qmail 31801 invoked by uid 500); 13 Sep 2016 15:22:20 -0000
Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@lucene.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@lucene.apache.org>
List-Post: <mailto:dev@lucene.apache.org>
List-Id: <dev.lucene.apache.org>
Reply-To: dev@lucene.apache.org
Delivered-To: mailing list dev@lucene.apache.org
Received: (qmail 31787 invoked by uid 99); 13 Sep 2016 15:22:20 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Sep 2016 15:22:20 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id 9BE382C1B77
	for <dev@lucene.apache.org>; Tue, 13 Sep 2016 15:22:20 +0000 (UTC)
Date: Tue, 13 Sep 2016 15:22:20 +0000 (UTC)
From: "Steve Rowe (JIRA)" <jira@apache.org>
To: dev@lucene.apache.org
Message-ID: <JIRA.13004179.1473629394000.560031.1473780140634@Atlassian.JIRA>
In-Reply-To: <JIRA.13004179.1473629394000@Atlassian.JIRA>
References: <JIRA.13004179.1473629394000@Atlassian.JIRA> <JIRA.13004179.1473629394522@arcas>
Subject: [jira] [Commented] (LUCENE-7446) Fix back-compat version check in
 addVersion helper script
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
archived-at: Tue, 13 Sep 2016 15:22:22 -0000


    [ https://issues.apache.org/jira/browse/LUCENE-7446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15487497#comment-15487497 ] 

Steve Rowe commented on LUCENE-7446:
------------------------------------

Using the script with my patch applied, following are the versions I successfully added on the given branches ("Context" refers to the three contexts in which {{addVersion.py}} is used - see my previous comment):

||Context||Version added||Branch||
|1|5.5.5|branch_5_5|
|1|6.2.2|branch_6_2|
|1|6.4.0|branch_6x|
|1|8.0.0|master|
|2|6.2.2|branch_6x|
|2|6.2.2|master|
|3|4.10.5|branch_6x|
|3|5.5.4|master|

Committing shortly.

> Fix back-compat version check in addVersion helper script
> ---------------------------------------------------------
>
>                 Key: LUCENE-7446
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7446
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Anshum Gupta
>            Assignee: Anshum Gupta
>            Priority: Minor
>         Attachments: LUCENE-7446.patch, LUCENE-7446.patch
>
>
> As part of the 5.5.3 post-release process, I was trying to bump up the number to 5.5.4 on the release branch but ran into the following error:
> {code}
> Traceback (most recent call last):
>   File "dev-tools/scripts/addVersion.py", line 246, in <module>
>     main()
>   File "dev-tools/scripts/addVersion.py", line 221, in main
>     if current_version.is_back_compat_with(c.version):
>   File "/Users/anshumgupta/workspace/lucene-solr/dev-tools/scripts/scriptutil.py", line 75, in is_back_compat_with
>     raise Exception('Back compat check disallowed for newer version: %s < %s' % (self, other))
> Exception: Back compat check disallowed for newer version: 5.5.3 < 5.5.4
> {code}
> I think the check is wrong and should be reversed. I'll post a patch that I used to work around this but would be good to have more eyes on this before I commit this.
> [~steve_rowe]: Can you take a look at the patch as I guess you added this recently.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org