Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@lucene.apache.org
MIME-Version: 1.0
References: <CABEwPvE0Lx5v7MMroSKijV4hdYZZmPdjfnu1_PQVYgrWFga65A@mail.gmail.com>
In-Reply-To: <CABEwPvE0Lx5v7MMroSKijV4hdYZZmPdjfnu1_PQVYgrWFga65A@mail.gmail.com>
From: David Smiley <david.w.smiley@gmail.com>
Date: Fri, 30 Sep 2016 20:30:28 +0000
Message-ID: <CABEwPvHnsujmQaSo9-Ye579mu_tTWKbJ3Q2YmxXjsRZb1OBXQQ@mail.gmail.com>
Subject: Re: SolrJ 6.2 now depends on Google-Guava and Jackson WTF?!
To: "dev@lucene.apache.org" <dev@lucene.apache.org>
Content-Type: multipart/alternative; boundary=001a1144728ea9a4f4053dbf7756
archived-at: Fri, 30 Sep 2016 20:30:46 -0000

--001a1144728ea9a4f4053dbf7756
Content-Type: text/plain; charset=UTF-8

Furthermore, changes to SolrJ dependencies should be noted clearly in
CHANGES.txt (e.g. new SolrJ dependency XYZ for purpose ___, or updated
SolrJ dependency XYZ to 1.2.3).  I see no reference to this in CHANGES.txt.

On Fri, Sep 30, 2016 at 4:24 PM David Smiley <david.w.smiley@gmail.com>
wrote:

> I was updating a project of mine today from SolrJ 6.0.0 to 6.2.1 and ran
> into a classpath incompatibility problem pertaining to Guava.  I execute
> "mvn dependency:tree" to see what's going on and I see a huge WTF -- SolrJ
> depends on Guava!  Since when?!  6.2.0 apparently and in this issue --
> https://issues.apache.org/jira/browse/SOLR-9200    Oh wow it depends on
> Jackson now too!
>
> Sorry, this is not okay and I feel strongly about this.  Very deliberate
> care should be taken to our SolrJ dependencies since they are used in many
> environments, and dependencies there add a burden on anyone using Solr.
>  **Adding SolrJ dependencies should be announced**; either in their own
> issue with appropriate title or noted in the dev list (not a JIRA issue) so
> as to be noticed.  Can we agree to do this from now on?
>
> Fortunately, it *appears* that the usage is pretty minimal?  Greg Chanan /
> Steve Rowe, it appears the Guava dependency is just a couple import
> statements for annotations.  Is that it?  I manually excluded guava from my
> SolrJ dependency in the pom.xml along with things like Woodstox which I
> always exclude.  I'm not sure yet about the scope of Jackson; we haven't
> needed that to date as we've got Noggit.
>
> ~ David
> --
> Lucene/Solr Search Committer, Consultant, Developer, Author, Speaker
> LinkedIn: http://linkedin.com/in/davidwsmiley | Book:
> http://www.solrenterprisesearchserver.com
>
-- 
Lucene/Solr Search Committer, Consultant, Developer, Author, Speaker
LinkedIn: http://linkedin.com/in/davidwsmiley | Book:
http://www.solrenterprisesearchserver.com

--001a1144728ea9a4f4053dbf7756
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Furthermore, changes to SolrJ dependencies should be noted=
 clearly in CHANGES.txt (e.g. new SolrJ dependency XYZ for purpose ___, or =
updated SolrJ dependency XYZ to 1.2.3).=C2=A0 I see no reference to this in=
 CHANGES.txt.<br><br><div class=3D"gmail_quote"><div dir=3D"ltr">On Fri, Se=
p 30, 2016 at 4:24 PM David Smiley &lt;<a href=3D"mailto:david.w.smiley@gma=
il.com">david.w.smiley@gmail.com</a>&gt; wrote:<br></div><blockquote class=
=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padd=
ing-left:1ex"><div dir=3D"ltr">I was updating a project of mine today from =
SolrJ 6.0.0 to 6.2.1 and ran into a classpath incompatibility problem perta=
ining to Guava.=C2=A0 I execute &quot;mvn dependency:tree&quot; to see what=
&#39;s going on and I see a huge WTF -- SolrJ depends on Guava!=C2=A0 Since=
 when?! =C2=A06.2.0 apparently and in this issue --=C2=A0<a href=3D"https:/=
/issues.apache.org/jira/browse/SOLR-9200" target=3D"_blank">https://issues.=
apache.org/jira/browse/SOLR-9200</a>=C2=A0 =C2=A0 Oh wow it depends on Jack=
son now too!<div><br></div><div>Sorry, this is not okay and I feel strongly=
 about this.=C2=A0 Very deliberate care should be taken to our SolrJ depend=
encies since they are used in many environments, and dependencies there add=
 a burden on anyone using Solr. =C2=A0**Adding SolrJ dependencies should be=
 announced**; either in their own issue with appropriate title or noted in =
the dev list (not a JIRA issue) so as to be noticed.=C2=A0 Can we agree to =
do this from now on?</div><div><br></div><div>Fortunately, it *appears* tha=
t the usage is pretty minimal?=C2=A0 Greg Chanan / Steve Rowe, it appears t=
he Guava dependency is just a couple import statements for annotations.=C2=
=A0 Is that it?=C2=A0 I manually excluded guava from my SolrJ dependency in=
 the pom.xml along with things like Woodstox which I always exclude.=C2=A0 =
I&#39;m not sure yet about the scope of Jackson; we haven&#39;t needed that=
 to date as we&#39;ve got Noggit.</div><div><br></div><div>~ David</div></d=
iv><div dir=3D"ltr">-- <br></div><div data-smartmail=3D"gmail_signature"><d=
iv dir=3D"ltr"><div>Lucene/Solr Search Committer, Consultant, Developer, Au=
thor, Speaker<div>LinkedIn: <a href=3D"http://linkedin.com/in/davidwsmiley"=
 target=3D"_blank">http://linkedin.com/in/davidwsmiley</a> | Book:=C2=A0<a =
href=3D"http://www.solrenterprisesearchserver.com" target=3D"_blank">http:/=
/www.solrenterprisesearchserver.com</a></div></div></div></div></blockquote=
></div></div><div dir=3D"ltr">-- <br></div><div data-smartmail=3D"gmail_sig=
nature"><div dir=3D"ltr"><div>Lucene/Solr Search Committer, Consultant, Dev=
eloper, Author, Speaker<div>LinkedIn: <a href=3D"http://linkedin.com/in/dav=
idwsmiley">http://linkedin.com/in/davidwsmiley</a> | Book:=C2=A0<a href=3D"=
http://www.solrenterprisesearchserver.com">http://www.solrenterprisesearchs=
erver.com</a></div></div></div></div>

--001a1144728ea9a4f4053dbf7756--