lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anshum Gupta (JIRA)" <>
Subject [jira] [Commented] (LUCENE-7446) Fix back-compat version check in addVersion helper script
Date Sun, 11 Sep 2016 21:32:20 GMT


Anshum Gupta commented on LUCENE-7446:

This patch allows for running the script with a higher version, not with the same version.

I am not sure but I think we might want to support running the script with the current version
to be able to re-run this on failure.

> Fix back-compat version check in addVersion helper script
> ---------------------------------------------------------
>                 Key: LUCENE-7446
>                 URL:
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Anshum Gupta
>            Assignee: Anshum Gupta
>            Priority: Minor
>         Attachments: LUCENE-7446.patch
> As part of the 5.5.3 post-release process, I was trying to bump up the number to 5.5.4
on the release branch but ran into the following error:
> {code}
> Traceback (most recent call last):
>   File "dev-tools/scripts/", line 246, in <module>
>     main()
>   File "dev-tools/scripts/", line 221, in main
>     if current_version.is_back_compat_with(c.version):
>   File "/Users/anshumgupta/workspace/lucene-solr/dev-tools/scripts/", line
75, in is_back_compat_with
>     raise Exception('Back compat check disallowed for newer version: %s < %s' % (self,
> Exception: Back compat check disallowed for newer version: 5.5.3 < 5.5.4
> {code}
> I think the check is wrong and should be reversed. I'll post a patch that I used to work
around this but would be good to have more eyes on this before I commit this.
> [~steve_rowe]: Can you take a look at the patch as I guess you added this recently.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message