lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Smiley (JIRA)" <>
Subject [jira] [Created] (SOLR-9501) Collapse filter should sometimes be cacheable instead of never
Date Sun, 11 Sep 2016 20:19:20 GMT
David Smiley created SOLR-9501:

             Summary: Collapse filter should sometimes be cacheable instead of never
                 Key: SOLR-9501
             Project: Solr
          Issue Type: Improvement
      Security Level: Public (Default Security Level. Issues are Public)
            Reporter: David Smiley

When SolrIndexSearcher.getDocSet(List<Query>queries) is called, it first checks if any
implement the marker interface ScoreFilter, and if so it calls out to getDocSetScore\[1] instead
of continuing.  CollapsingPostFilter is the only Query implementing ScoreFilter.  There is
a presumption here that any CollapsingPostFilter needs the score.  But this just isn't true;
you can collapse with a min/max/sort on something that doesn't need the score.  So there is
a needless performance hit here.

 \[1] I don't like that getDocSetScore presumes the first query in the list is the scoring
one -- it's a poor API contract relationship; at a minimum the javadocs should be updated.
 This holds for getDocSet as well since it passes through. Perhaps getDocSet could be modified
to take a nullable scoring Query first arg.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message