lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-9494) CollapseQParserPlugin doesn't propagate needsScores() correctly
Date Sun, 11 Sep 2016 18:31:20 GMT

    [ https://issues.apache.org/jira/browse/SOLR-9494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15482202#comment-15482202
] 

ASF subversion and git services commented on SOLR-9494:
-------------------------------------------------------

Commit a029c8ede6ae625932a87c38ca7fca1c4402c48f in lucene-solr's branch refs/heads/branch_6x
from [~dsmiley]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=a029c8e ]

SOLR-9494: CollapseQParser's collectors should override needsScores(); can trigger exceptions
Also, field cscore was not needed.

(cherry picked from commit d2fcc3d)


> CollapseQParserPlugin doesn't propagate needsScores() correctly
> ---------------------------------------------------------------
>
>                 Key: SOLR-9494
>                 URL: https://issues.apache.org/jira/browse/SOLR-9494
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: David Smiley
>            Assignee: David Smiley
>         Attachments: SOLR_9494__CollapseQParser_s_collectors_should_override_needsScores__.patch
>
>
> CollapseQParserPlugin internally has a number of Lucene Collector implementations, all
of which extend Solr DelegatingCollector which provides a default implementation of the method
needsScores() based on what it's delegating too.  But Collapsing's collectors fail to consider
that these collectors _themselves_ sometimes need the score, irrespective of wether or not
a delegate might.
> In most cases nobody would notice this bug because most queries don't seem to care. 
However, SpanQueries are cranky about this, which will either throw an AssertionError or NPE
if you ask for a score without saying in advance you wanted them.
> I have a patch forthcoming, but am having trouble ATM reproducing to create a test. 
The most straight-forward test doesn't trip it.  I have a failing test in a client environment,
and a patch that fixes it.  Reproducing seems to involve a cached query somehow.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message