lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-9467) Document Transformer to Remove Fields
Date Tue, 06 Sep 2016 23:37:20 GMT

    [ https://issues.apache.org/jira/browse/SOLR-9467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15468960#comment-15468960
] 

Hoss Man commented on SOLR-9467:
--------------------------------

Idea seems fine in principle, but i'm wondering what the semantics should be in cases like...

# {{fl=*&fl=some_alias:\[fl.rm v=long_title\]}}
# {{fl=*,some_alias:long_title&fl=\[fl.rm v=some_alias\]}}
# {{fl=*,some_alias:long_title&fl=\[fl.rm v=long_title\]}}

#1 seems like a nonsensical request, so I would say it's fine to just ignore the "some_alias"
specified.

#2 might look silly, but imagine if the first fl param is in some solrconfig.xml hardcoded
"appends" params, and the second fl is supplied by the client who has no idea that "some_alias"
isn't a real field name ... seems like a common case that should result in "some_alias" being
suppressed from the response -- if it's not it will be confusing as hell.

#3 is ... i honestly have no idea what the right behavior should be for #3 ... something to
think about though, and at a minimum have a test demonstrating it for refrence.

As far  as naming goes: i would suggest that {{\[remove field=long_title\]}} would be a better
syntax ... or maybe {{\[hide field=long_title\]}}

As far as test cases: please ensure that this new transformer is adequately covered in the
following test classes so we don't keep running into the types of bugs that lead to needing
these test classes in the first place (ex: SOLR-9180, SOLR-9314, etc...)

* TestPseudoReturnFields
* TestCloudPseudoReturnFields
* TestRandomFlRTGCloud

> Document Transformer to Remove Fields
> -------------------------------------
>
>                 Key: SOLR-9467
>                 URL: https://issues.apache.org/jira/browse/SOLR-9467
>             Project: Solr
>          Issue Type: New Feature
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: SearchComponents - other
>    Affects Versions: 6.2
>            Reporter: Gus Heck
>         Attachments: SOLR-9467.patch
>
>
> Given that SOLR-3191 has become bogged down and inactive, evidently stuck in low level
details, and since I have wished several times for some way to just get that one big field
out of my results to improve transfer times without making a big brittle list of all my other
fields. I'd like to propose a DocumentTransformer that accomplishes this.
> It would look something like this:
> {code}&fl=*,[fl.rm v="title"]{code} 
> Since removing one field with a known name is probably the most common case I'd like
to start by keeping this simple, and if further features like globs or lists of fields are
desired, subsequent Jira tickets can be opened to add them. Not attached to specifics here,
only looking to keep things simple and solve the key use case. If you don't like fl.rm as
a name for a transformer, suggest a better one (for example). 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message