lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Høydahl (JIRA) <j...@apache.org>
Subject [jira] [Issue Comment Deleted] (SOLR-8033) useless if branch (commented out log.debug in HdfsTransactionLog constructor)
Date Wed, 28 Sep 2016 07:50:20 GMT

     [ https://issues.apache.org/jira/browse/SOLR-8033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jan Høydahl updated SOLR-8033:
------------------------------
    Comment: was deleted

(was: Commit 1716160 from [~ehatcher] in branch 'dev/trunk'
[ https://svn.apache.org/r1716160 ]

SOLR-8033: document the move of EmptyEntityResolver)

> useless if branch (commented out log.debug in HdfsTransactionLog constructor)
> -----------------------------------------------------------------------------
>
>                 Key: SOLR-8033
>                 URL: https://issues.apache.org/jira/browse/SOLR-8033
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: 5.0, 5.1
>            Reporter: songwanging
>            Priority: Minor
>              Labels: newdev
>
> In method HdfsTransactionLog() of class HdfsTransactionLog (solr\core\src\java\org\apache\solr\update\HdfsTransactionLog.java)
> The if branch presented in the following code snippet performs no actions, we should
add more code to handle this or directly delete this if branch.
> HdfsTransactionLog(FileSystem fs, Path tlogFile, Collection<String> globalStrings,
boolean openExisting) {
>   ...
>     try {
>       if (debug) {
>         //log.debug("New TransactionLog file=" + tlogFile + ", exists=" + tlogFile.exists()
+ ", size=" + tlogFile.length() + ", openExisting=" + openExisting);
>       }
> ...
> }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message