lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From uschindler <...@git.apache.org>
Subject [GitHub] lucene-solr pull request #74: [SOLR-9444] Fix path usage for cloud backup/re...
Date Fri, 02 Sep 2016 07:03:29 GMT
Github user uschindler commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/74#discussion_r77301896
  
    --- Diff: solr/core/src/test/org/apache/solr/cloud/TestLocalFSCloudBackupRestore.java
---
    @@ -24,12 +24,20 @@
      * such file-system would be exposed via local file-system API.
      */
     public class TestLocalFSCloudBackupRestore extends AbstractCloudBackupRestoreTestCase
{
    +  private static String backupLocation;
     
       @BeforeClass
       public static void setupClass() throws Exception {
         configureCluster(NUM_SHARDS)// nodes
             .addConfig("conf1", TEST_PATH().resolve("configsets").resolve("cloud-minimal").resolve("conf"))
             .configure();
    +
    +    boolean whitespacesInPath = random().nextBoolean();
    +    if (whitespacesInPath) {
    +      backupLocation = createTempDir("my backup").toFile().getAbsolutePath();
    --- End diff --
    
    I'd use `backupLocation = createTempDir(...).toAbsolutePath().toString();` to get rid
of legacy `java.io.File`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message