Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 0F533200B73 for ; Mon, 29 Aug 2016 17:53:28 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id E91BA160AB8; Mon, 29 Aug 2016 15:53:22 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 38FF0160A89 for ; Mon, 29 Aug 2016 17:53:22 +0200 (CEST) Received: (qmail 57350 invoked by uid 500); 29 Aug 2016 15:53:21 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 57317 invoked by uid 99); 29 Aug 2016 15:53:21 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 29 Aug 2016 15:53:21 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id EBEDD2C014F for ; Mon, 29 Aug 2016 15:53:20 +0000 (UTC) Date: Mon, 29 Aug 2016 15:53:20 +0000 (UTC) From: "Noble Paul (JIRA)" To: dev@lucene.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (SOLR-9454) Reduce object allocation during indexing because of JavaBinCodec.writeExternString() MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 29 Aug 2016 15:53:28 -0000 [ https://issues.apache.org/jira/browse/SOLR-9454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul updated SOLR-9454: ----------------------------- Attachment: SOLR-9454.patch > Reduce object allocation during indexing because of JavaBinCodec.writeExternString() > ------------------------------------------------------------------------------------ > > Key: SOLR-9454 > URL: https://issues.apache.org/jira/browse/SOLR-9454 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: SolrCloud, update > Reporter: Shalin Shekhar Mangar > Labels: difficulty-medium, impact-medium > Fix For: master (7.0), 6.3 > > Attachments: SOLR-9454.patch > > > I setup Java Flight Recorder to profile indexing a 650MB JSON file using bin/post on 2 shard, 2 replica setup. It shows that the JavaBinCodec.writeExternString(String) method contributes a lot of garbage during indexing in SolrCloud. More specifically, it contributes ~1GB of HashMap$Node objects and ~450MB of HashMap$Node[] objects. > Most of this allocation is because every request is serialized using a new instance of JavaBinUpdateRequestCodec which internally allocates a new HashMap for storing the extern strings. > We should explore keeping a global extern string map to eliminate redundant allocations. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org