Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id EA566200B63 for ; Mon, 15 Aug 2016 14:02:22 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id E8F47160A6C; Mon, 15 Aug 2016 12:02:22 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 3E31F160AA7 for ; Mon, 15 Aug 2016 14:02:22 +0200 (CEST) Received: (qmail 21677 invoked by uid 500); 15 Aug 2016 12:02:20 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 21460 invoked by uid 99); 15 Aug 2016 12:02:20 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 Aug 2016 12:02:20 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 990F92C02AB for ; Mon, 15 Aug 2016 12:02:20 +0000 (UTC) Date: Mon, 15 Aug 2016 12:02:20 +0000 (UTC) From: "support.appc@npo-echelon.ru (JIRA)" To: dev@lucene.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (SOLR-9413) String.replace Function result is ignored in lucene/analysis/kuromoji CSVUtil.quoteEscape MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 15 Aug 2016 12:02:23 -0000 [ https://issues.apache.org/jira/browse/SOLR-9413?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D15420= 880#comment-15420880 ]=20 support.appc@npo-echelon.ru commented on SOLR-9413: --------------------------------------------------- =D0=97=D0=B4=D1=80=D0=B0=D0=B2=D1=81=D1=82=D0=B2=D1=83=D0=B9=D1=82=D0=B5, -= jira=20 =D0=92=D0=B0=D1=88 =D0=B7=D0=B0=D0=BF=D1=80=D0=BE=D1=81 =D0=BD=D0=B0=D1=85= =D0=BE=D0=B4=D0=B8=D1=82=D1=81=D1=8F =D0=B2 =D0=BE=D0=B1=D1=80=D0=B0=D0=B1= =D0=BE=D1=82=D0=BA=D0=B5. =D0=95=D0=BC=D1=83 =D0=BF=D1=80=D0=B8=D1=81=D0=B2=D0=BE=D0=B5=D0=BD =D1=81= =D0=BB=D0=B5=D0=B4=D1=83=D1=8E=D1=89=D0=B8=D0=B9 =D0=B8=D0=B4=D0=B5=D0=BD= =D1=82=D0=B8=D1=84=D0=B8=D0=BA=D0=B0=D1=82=D0=BE=D1=80: #15836. --------------------------------------------- > String.replace Function result is ignored in lucene/analysis/kuromoji CSV= Util.quoteEscape > -------------------------------------------------------------------------= ---------------- > > Key: SOLR-9413 > URL: https://issues.apache.org/jira/browse/SOLR-9413 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public)=20 > Affects Versions: 6.1 > Reporter: AppChecker > Priority: Minor > > Hello! > Code in the method [CSVUtil. quoteEscape|https://github.com/apache/lucene= -solr/blob/633a89c0376e3db5b8c7efe325cdc3a409e250e5/lucene/analysis/kuromoj= i/src/java/org/apache/lucene/analysis/ja/util/CSVUtil.java#L104] > {code:title=3DCSVUtil.java|borderStyle=3Dsolid} > if (result.indexOf('\"') >=3D 0) { > result.replace("\"", ESCAPED_QUOTE); > } > {code} > ignores the return value of the String.replace method. > Probably, is should be: > {code:title=3DCSVUtil.java|borderStyle=3Dsolid} > if (result.indexOf('\"') >=3D 0) { > result =3D result.replace("\"", ESCAPED_QUOTE); > } > {code} > This possible defect found by [static code analyzer AppChecker|http://cnp= o.ru/en/solutions/appchecker.php] -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org