lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "support.appc@npo-echelon.ru (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-9413) String.replace Function result is ignored in lucene/analysis/kuromoji CSVUtil.quoteEscape
Date Mon, 15 Aug 2016 12:02:20 GMT

    [ https://issues.apache.org/jira/browse/SOLR-9413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15420880#comment-15420880
] 

support.appc@npo-echelon.ru commented on SOLR-9413:
---------------------------------------------------


Здравствуйте, - jira 

Ваш запрос находится в обработке.
Ему присвоен следующий идентификатор: #15836.

---------------------------------------------





> String.replace Function result is ignored in lucene/analysis/kuromoji CSVUtil.quoteEscape
> -----------------------------------------------------------------------------------------
>
>                 Key: SOLR-9413
>                 URL: https://issues.apache.org/jira/browse/SOLR-9413
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>    Affects Versions: 6.1
>            Reporter: AppChecker
>            Priority: Minor
>
> Hello!
> Code in the method [CSVUtil. quoteEscape|https://github.com/apache/lucene-solr/blob/633a89c0376e3db5b8c7efe325cdc3a409e250e5/lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/util/CSVUtil.java#L104]
> {code:title=CSVUtil.java|borderStyle=solid}
>     if (result.indexOf('\"') >= 0) {
>       result.replace("\"", ESCAPED_QUOTE);
>     }
> {code}
> ignores the return value of the String.replace method.
> Probably, is should be:
> {code:title=CSVUtil.java|borderStyle=solid}
>     if (result.indexOf('\"') >= 0) {
>       result = result.replace("\"", ESCAPED_QUOTE);
>     }
> {code}
> This possible defect found by [static code analyzer AppChecker|http://cnpo.ru/en/solutions/appchecker.php]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message