lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-7373) Break out Directory.syncMetaData from FSDirectory.renameFile
Date Mon, 11 Jul 2016 13:23:11 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-7373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15370740#comment-15370740
] 

Robert Muir commented on LUCENE-7373:
-------------------------------------

+1

> Break out Directory.syncMetaData from FSDirectory.renameFile
> ------------------------------------------------------------
>
>                 Key: LUCENE-7373
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7373
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: master (7.0), 6.2
>
>         Attachments: LUCENE-7373.patch
>
>
> Today, when you call {{FSDirectory.renameFile}} it also calls fsync on
> the directory.
> This is OK for Lucene's current usage of this method, to rename just
> the one {{segments_N}} file on commit.
> But in playing with adding NRT replication (LUCENE-5438) to the simple
> demo Lucene server (LUCENE-5376) I found that, on spinning disks, that
> fsync is very costly, because when copying over an NRT point, we write
> to N .tmp files and then rename many files (taking seconds) in the
> end.
> I think we should just deprecate/remove the existing method, and make a new
> {{rename}} method that does only renaming, and a separate
> {{syncMetaData}} to call fsync on the directory?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message