lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-9277) Clean up some more remnants of supporting old and new style solr.xml in tests
Date Thu, 07 Jul 2016 04:04:10 GMT

    [ https://issues.apache.org/jira/browse/SOLR-9277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15365572#comment-15365572
] 

ASF subversion and git services commented on SOLR-9277:
-------------------------------------------------------

Commit 602a72ddade76931b90d59bd03365666c2835223 in lucene-solr's branch refs/heads/branch_6x
from Erick
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=602a72d ]

SOLR-9277: Clean up some more remnants of supporting old and new style solr.xml in tests
(cherry picked from commit 7743718)


> Clean up some more remnants of supporting old and new style solr.xml in tests
> -----------------------------------------------------------------------------
>
>                 Key: SOLR-9277
>                 URL: https://issues.apache.org/jira/browse/SOLR-9277
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Erick Erickson
>            Assignee: Erick Erickson
>            Priority: Minor
>         Attachments: beast-9277
>
>
> I have reason to look at the tests and I'm seeing a few remnants of old/new style Solr.xml
support (with and without <cores>). So far:
> > SolrTestCaseJ4.copySolrHomeToTemp with a flag whether old or new style.
> > solr-no-core.xml in test files. Mostly this is identical to solr.xml, here are the
differences:
> in solr-no-core.xml but not solr.xml
>     <int name="autoReplicaFailoverWaitAfterExpiration">${autoReplicaFailoverWaitAfterExpiration:10000}</int>
>     <int name="autoReplicaFailoverWorkLoopDelay">${autoReplicaFailoverWorkLoopDelay:10000}</int>
>     <int name="autoReplicaFailoverBadNodeExpiration">${autoReplicaFailoverBadNodeExpiration:60000}</int>
> in solr.xml but not in solr-no-cores.xml:
>     <int name="leaderVoteWait">${leaderVoteWait:10000}</int>
> The question here is whether moving the three properties in solr-no-cores.xml to solr.xml
 and using solr.xml in all the tests that currently use solr-no-cores.xml would mess up tests
and whether leaderVoteWait being in solr.xml would mess up tests currently using solr-no-cores.xml.
> I'll make a quick hack at this to see and we can discuss.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message