lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hgadre <...@git.apache.org>
Subject [GitHub] lucene-solr pull request #52: [SOLR-9269] Ability to create/delete/list snap...
Date Fri, 22 Jul 2016 05:15:59 GMT
Github user hgadre commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/52#discussion_r71827952
  
    --- Diff: solr/core/src/java/org/apache/solr/core/SolrCore.java ---
    @@ -414,7 +416,19 @@ private IndexDeletionPolicyWrapper initDeletionPolicy(IndexDeletionPolicyWrapper
         } else {
           delPolicy = new SolrDeletionPolicy();
         }
    -    return new IndexDeletionPolicyWrapper(delPolicy);
    +
    +    return new IndexDeletionPolicyWrapper(delPolicy, snapshotMgr);
    +  }
    +
    +  private SolrSnapshotMetaDataManager initSnapshotMetaDataManager() {
    --- End diff --
    
    I don't think directory creation should have any significant performance impact. Also
lazy creation just adds a bit of complexity in the code which I wanted to avoid. But I am
open to this idea if you insist.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message