lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From softwaredoug <...@git.apache.org>
Subject [GitHub] lucene-solr pull request #49: SOLR-9279 Adds comparison function queries
Date Wed, 06 Jul 2016 12:57:34 GMT
Github user softwaredoug commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/49#discussion_r69724481
  
    --- Diff: lucene/queries/src/java/org/apache/lucene/queries/function/valuesource/CompareNumericFunction.java
---
    @@ -0,0 +1,131 @@
    +package org.apache.lucene.queries.function.valuesource;
    +
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +import java.io.IOException;
    +import java.util.Map;
    +
    +import org.apache.lucene.index.LeafReaderContext;
    +import org.apache.lucene.queries.function.ValueSource;
    +import org.apache.lucene.queries.function.FunctionValues;
    +import org.apache.lucene.search.IndexSearcher;
    +
    +
    +/**
    + * Base class for comparison operators used within if statements
    + * To Solr's if function query a 0 is considered "false", all other values are "true"
    + */
    +public abstract class CompareNumericFunction extends ValueSource {
    --- End diff --
    
    I thought about BoolFunction, but it seemed unused. I certainly could with no change,
it would only have documentation value.
    
    Would removing "value" imply this also works on strings? I'm not thoroughly versed here
but when I was looking at IfFunction, I intentionally omitted non-numeric comparions (ie string
comparisons). Hence the name. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message