lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dsmiley <>
Subject [GitHub] lucene-solr pull request #49: SOLR-9279 Adds comparison function queries
Date Wed, 06 Jul 2016 03:51:01 GMT
Github user dsmiley commented on a diff in the pull request:
    --- Diff: lucene/queries/src/java/org/apache/lucene/queries/function/valuesource/
    @@ -0,0 +1,131 @@
    +package org.apache.lucene.queries.function.valuesource;
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +import java.util.Map;
    +import org.apache.lucene.index.LeafReaderContext;
    +import org.apache.lucene.queries.function.ValueSource;
    +import org.apache.lucene.queries.function.FunctionValues;
    + * Base class for comparison operators used within if statements
    + * To Solr's if function query a 0 is considered "false", all other values are "true"
    + */
    +public abstract class CompareNumericFunction extends ValueSource {
    --- End diff --
    Maybe rename ComparisonPredicateValueSource?  Using "predicate" seems appropriate; Numeric
seems redundant with anything ValueSource.  Not sure on Function suffix; there's sadly a mix
in Lucene but I think it's better to prefer the subclass's name.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message