lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-7362) Implement FieldInfos and FieldInfo toString()
Date Wed, 29 Jun 2016 13:10:37 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-7362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15355210#comment-15355210
] 

Robert Muir commented on LUCENE-7362:
-------------------------------------

I do not think they should. These are low level structures: i think the current toString is
just fine, e.g. to know you have the right one in indexwriter and so on.

I think this is also relevant to LUCENE-7361. MemoryIndex is a toy 1 document thing, we should
not add dangerous things to low level lucene structures (like loops over fields) that will
blow up. 

I also do not care at all for the magical coded flags that solr uses here. The current toString
is more useful to me than that, so it would just lose usefulness. If we want FieldInfo *not
plural* to have a different toString it should simply print out all of the flags by name and
value with no screwing around.

> Implement FieldInfos and FieldInfo toString()
> ---------------------------------------------
>
>                 Key: LUCENE-7362
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7362
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/index
>            Reporter: David Smiley
>
> FieldInfos and FieldInfo ought to override toString().  Perhaps FieldInfo.toString()
can look like the pattern popularized by Luke, also seen in Solr?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message