Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@lucene.apache.org
From: dragonsinth <git@git.apache.org>
To: dev@lucene.apache.org
Reply-To: dev@lucene.apache.org
References: <git-pr-32-lucene-solr@git.apache.org>
In-Reply-To: <git-pr-32-lucene-solr@git.apache.org>
Subject: [GitHub] lucene-solr pull request: SOLR-8323
Content-Type: text/plain
Message-Id: <20160510232911.3FA71DFE04@git1-us-west.apache.org>
Date: Tue, 10 May 2016 23:29:11 +0000 (UTC)
archived-at: Tue, 10 May 2016 23:29:13 -0000

Github user dragonsinth commented on the pull request:

    https://github.com/apache/lucene-solr/pull/32#issuecomment-218321437
  
    Almost LGTM.  There's a few nits, but the only real issue is potentially setting up a StateWatcher on legacy.
    
    Nice work, I think we're almost done!!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org