lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chris Hostetter <hossman_luc...@fucit.org>
Subject Re: lucene-solr:master: remove unnecessary Placeholder and mark old codec deprecated
Date Fri, 13 May 2016 17:00:56 GMT

I don't have git repo handy to verify, but I think this may have broken 
precommit and be causing some recent jenkins failures?

http://jenkins.thetaphi.de/job/Lucene-Solr-master-Solaris/576/consoleText
:      [copy] Copying 1 file to /export/home/jenkins/workspace/Lucene-Solr-master-Solaris/lucene/build/docs/backward-codecs
	...
:   [javadoc] Loading source files for package org.apache.lucene.codecs...
:   [javadoc] javadoc: warning - No source files for package org.apache.lucene.codecs
        ...
: /export/home/jenkins/workspace/Lucene-Solr-6.x-Solaris/lucene/common-build.xml:2163: Javadocs
warnings were found!






On Fri, 13 May 2016, rmuir@apache.org wrote:

: Date: Fri, 13 May 2016 01:13:45 +0000 (UTC)
: From: rmuir@apache.org
: Reply-To: dev@lucene.apache.org
: To: commits@lucene.apache.org
: Subject: lucene-solr:master: remove unnecessary Placeholder and mark old codec
:      deprecated
: 
: Repository: lucene-solr
: Updated Branches:
:   refs/heads/master 062869626 -> 06034c247
: 
: 
: remove unnecessary Placeholder and mark old codec deprecated
: 
: 
: Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
: Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/06034c24
: Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/06034c24
: Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/06034c24
: 
: Branch: refs/heads/master
: Commit: 06034c247499f50b228dc86445bc8b4725016ca5
: Parents: 0628696
: Author: Robert Muir <rmuir@apache.org>
: Authored: Thu May 12 21:13:26 2016 -0400
: Committer: Robert Muir <rmuir@apache.org>
: Committed: Thu May 12 21:13:26 2016 -0400
: 
: ----------------------------------------------------------------------
:  .../org/apache/lucene/codecs/Placeholder.java   | 23 --------------------
:  .../lucene/codecs/lucene54/Lucene54Codec.java   |  2 ++
:  2 files changed, 2 insertions(+), 23 deletions(-)
: ----------------------------------------------------------------------
: 
: 
: http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/06034c24/lucene/backward-codecs/src/java/org/apache/lucene/codecs/Placeholder.java
: ----------------------------------------------------------------------
: diff --git a/lucene/backward-codecs/src/java/org/apache/lucene/codecs/Placeholder.java b/lucene/backward-codecs/src/java/org/apache/lucene/codecs/Placeholder.java
: deleted file mode 100644
: index b0c292b..0000000
: --- a/lucene/backward-codecs/src/java/org/apache/lucene/codecs/Placeholder.java
: +++ /dev/null
: @@ -1,23 +0,0 @@
: -/*
: - * Licensed to the Apache Software Foundation (ASF) under one or more
: - * contributor license agreements.  See the NOTICE file distributed with
: - * this work for additional information regarding copyright ownership.
: - * The ASF licenses this file to You under the Apache License, Version 2.0
: - * (the "License"); you may not use this file except in compliance with
: - * the License.  You may obtain a copy of the License at
: - *
: - *     http://www.apache.org/licenses/LICENSE-2.0
: - *
: - * Unless required by applicable law or agreed to in writing, software
: - * distributed under the License is distributed on an "AS IS" BASIS,
: - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
: - * See the License for the specific language governing permissions and
: - * limitations under the License.
: - */
: -package org.apache.lucene.codecs;
: -
: -
: -/** Remove this file when adding back compat codecs */
: -public class Placeholder {
: -  
: -}
: 
: http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/06034c24/lucene/backward-codecs/src/java/org/apache/lucene/codecs/lucene54/Lucene54Codec.java
: ----------------------------------------------------------------------
: diff --git a/lucene/backward-codecs/src/java/org/apache/lucene/codecs/lucene54/Lucene54Codec.java
b/lucene/backward-codecs/src/java/org/apache/lucene/codecs/lucene54/Lucene54Codec.java
: index 2dde0cf..d982d3b 100644
: --- a/lucene/backward-codecs/src/java/org/apache/lucene/codecs/lucene54/Lucene54Codec.java
: +++ b/lucene/backward-codecs/src/java/org/apache/lucene/codecs/lucene54/Lucene54Codec.java
: @@ -51,7 +51,9 @@ import org.apache.lucene.codecs.perfield.PerFieldPostingsFormat;
:   *
:   * @see org.apache.lucene.codecs.lucene54 package documentation for file format details.
:   * @lucene.experimental
: + * @deprecated Only for 5.x back compat
:   */
: +@Deprecated
:  public class Lucene54Codec extends Codec {
:    private final TermVectorsFormat vectorsFormat = new Lucene50TermVectorsFormat();
:    private final FieldInfosFormat fieldInfosFormat = new Lucene50FieldInfosFormat();
: 
: 

-Hoss
http://www.lucidworks.com/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message