lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Misha Dmitriev (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-9109) Add support for custom ivysettings.xml
Date Mon, 16 May 2016 17:54:13 GMT

    [ https://issues.apache.org/jira/browse/SOLR-9109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15284937#comment-15284937
] 

Misha Dmitriev commented on SOLR-9109:
--------------------------------------

Regarding Lucene vs Solr: please note that both before and after my change all the changes
are confined to Lucene's common-build.xml file. It would be good to understand whether my
change makes any difference wrt. the visibility of properties defined in ivy-versions.properties.
Perhaps an experiment demonstrating that after the change the properties propagate somewhere
they are not supposed to be visible?

As for including ivy-versions.properties in the new user-supplied ivysettings.xml. The whole
point of making my change is to make all CDH components use the same single ivysettings.xml
file, that just defines several supported locations to download artifacts from. Adding Solr-specific
stuff to it may cause problems for other components. We can, in the worst case, play some
tricks. Like, create at run time a customized copy of our ivysettings.xml with ivy-versions.properties
"injected" into it. But this is obviously not pretty. So it would be good to understand the
exact reason why we need such a special effort.

> Add support for custom ivysettings.xml
> --------------------------------------
>
>                 Key: SOLR-9109
>                 URL: https://issues.apache.org/jira/browse/SOLR-9109
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Misha Dmitriev
>         Attachments: 0001-Support-for-custom-ivysettings.xml.patch, SOLR-9109.patch
>
>
> Currently solr/lucene/common-build.xml hardcodes file ivy-settings.xml in the ivy.configure
task. It means that, unlike all other CDH components that use Ant, Solr does not allow the
user to provide a custom ivysettings.xml.
> In the Cauldron CDH build, we need to make some adjustments in the build process to satisfy
CDH-internal build dependencies with artifacts generated locally, rather than download them
from repo1.maven.org etc. E.g. all component should use locally-generated avro-snapshot jars
instead of publicly released ones, etc. For Ant, we achieve that by giving it a special ivysettings.xml
file, that limits artifact downloading to the local on-disk maven repository and Cloudera
artifactory server.
> All CDH components except Solr allow the user to specify a custom ivysettings.xml file
by overriding -Divysettings.xml property. We need to add the same feature to Solr. It can
be easily achieved by changing several lines in solr/lucene/common-build.xml.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message