lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Rowe (JIRA)" <j...@apache.org>
Subject [jira] [Reopened] (SOLR-9093) fix TopGroupsShardResponseProcessor.java:105 NullPointerException
Date Fri, 20 May 2016 22:03:12 GMT

     [ https://issues.apache.org/jira/browse/SOLR-9093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Steve Rowe reopened SOLR-9093:
------------------------------

Reopening to backport to 6.0.1.

> fix TopGroupsShardResponseProcessor.java:105 NullPointerException
> -----------------------------------------------------------------
>
>                 Key: SOLR-9093
>                 URL: https://issues.apache.org/jira/browse/SOLR-9093
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Christine Poerschke
>            Assignee: Christine Poerschke
>            Priority: Minor
>             Fix For: 5.6, 6.1, master (7.0)
>
>
> e.g. http://jenkins.thetaphi.de/job/Lucene-Solr-master-Linux/16693/testReport/junit/org.apache.solr/TestDistributedSearch/test/
> {code}
> org.apache.solr.client.solrj.impl.HttpSolrClient$RemoteSolrException: Error from server
at http://127.0.0.1:44706//collection1: java.lang.NullPointerException
> 	at org.apache.solr.search.grouping.distributed.responseprocessor.TopGroupsShardResponseProcessor.process(TopGroupsShardResponseProcessor.java:105)
> 	at org.apache.solr.handler.component.QueryComponent.handleGroupedResponses(QueryComponent.java:753)
> 	at org.apache.solr.handler.component.QueryComponent.handleResponses(QueryComponent.java:736)
> 	at org.apache.solr.handler.component.SearchHandler.handleRequestBody(SearchHandler.java:420)
> 	at org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:155)
> 	at org.apache.solr.core.SolrCore.execute(SolrCore.java:2016)
> ...
> {code}
> A minimalistic fix would be
> {code}
> -          if (t instanceof SolrServerException) {
> +          if (t instanceof SolrServerException && t.getCause() != null) {
> {code}
> but perhaps equally valid would be to tweak the logic, similar to the [SearchHandler.java#L440|https://github.com/apache/lucene-solr/blob/master/solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java#L440]
logic, the difference being cause vs. root-cause for SolrServerException exceptions and throwable
vs. throwable.cause for other exceptions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message