lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-7268) Remove ArrayUtil.timSort?
Date Sun, 01 May 2016 20:06:13 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-7268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15265917#comment-15265917
] 

Robert Muir commented on LUCENE-7268:
-------------------------------------

The javadocs for this arrays.sort method explicitly state timsort. Polygon edges are always
clockwise or counterclockwise so kinda sorted already... So i think timsort makes sense? 

But other use cases like index sorting have a similar situation... If there is a perf bug
here it could be affecting many things

> Remove ArrayUtil.timSort?
> -------------------------
>
>                 Key: LUCENE-7268
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7268
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Robert Muir
>         Attachments: LUCENE-7268_mods.patch
>
>
> Is there some workload where our timSort is better than the JDK one? Should we just remove
ours if its slower?
> Not that its a great test, but i switched Polygon2D edge sorting (just the one where
it says "sort the edges then build a balanced tree from them") from Arrays.sort to ArrayUtil.timSort
and was surprised when performance was much slower for an enormous polygon (http://people.apache.org/~mikemccand/geobench/cleveland.poly.txt.gz)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message