lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-9016) SolrIdentifierValidator accepts empty names
Date Tue, 26 Apr 2016 15:22:13 GMT

    [ https://issues.apache.org/jira/browse/SOLR-9016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15258263#comment-15258263
] 

ASF subversion and git services commented on SOLR-9016:
-------------------------------------------------------

Commit 9166647918d26fd75ae48d993e9191ad8d943fe3 in lucene-solr's branch refs/heads/master
from [~shaie]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=9166647 ]

SOLR-9016: Fix SolrIdentifierValidator to not accept empty identifiers


> SolrIdentifierValidator accepts empty names
> -------------------------------------------
>
>                 Key: SOLR-9016
>                 URL: https://issues.apache.org/jira/browse/SOLR-9016
>             Project: Solr
>          Issue Type: Bug
>          Components: Server
>            Reporter: Shai Erera
>             Fix For: 5.5.1, 6.1, 6.0.1
>
>         Attachments: SOLR-9016.patch
>
>
> SolrIdentifierValidator accepts shard, collection, cores and alias names following this
pattern:
> {code}
> ^(?!\\-)[\\._A-Za-z0-9\\-]*$
> {code}
> This accepts an "empty" name. This is easily fixable by changing the {{\*}} to {{+}}.
However, it also accepts names such as {{..}}, {{,__---}} etc. Do we not want to require collection
names to have a letter/digit identifier in them? Something like the following pattern:
> {code}
> ^(\\.)?[a-zA-Z0-9]+[\\._\\-a-zA-Z0-9]*$
> {code}
> That pattern requires the name to start with an optional {{.}} followed by a series of
letters/digits followed by the rest of the allowed characters.
> What do you think?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message