lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shalin Shekhar Mangar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-9014) Deprecate and reduce usage of ClusterState methods which may make calls to ZK via the lazy collection reference
Date Mon, 25 Apr 2016 20:37:12 GMT

    [ https://issues.apache.org/jira/browse/SOLR-9014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15257000#comment-15257000
] 

Shalin Shekhar Mangar commented on SOLR-9014:
---------------------------------------------

[~dragonsinth] -- In SOLR-6629, we added a CollectionRef.get() call in ClusterState.getCollections
but reading the code again, I no longer understand why it was necessary. Is there ever a chance
that the collectionStates inside ClusterState.java would ever have a collection that cannot
be resolved?

> Deprecate and reduce usage of ClusterState methods which may make calls to ZK via the
lazy collection reference
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-9014
>                 URL: https://issues.apache.org/jira/browse/SOLR-9014
>             Project: Solr
>          Issue Type: Improvement
>          Components: SolrCloud
>            Reporter: Shalin Shekhar Mangar
>             Fix For: master, 6.1
>
>         Attachments: SOLR-9014.patch
>
>
> ClusterState has a bunch of methods such as getSlice and getReplica which internally
call getCollectionOrNull that ends up making a call to ZK via the lazy collection reference.
Many classes use these methods even though a DocCollection object is available. In such cases,
multiple redundant calls to ZooKeeper can happen if the collection is not watched locally.
This is especially true for Overseer classes which operate on all collections.
> We should audit all usages of these methods and replace them with calls to appropriate
DocCollection methods.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message