lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-7179) GeoPoint and LatLonPoint test data should quantize once
Date Tue, 05 Apr 2016 18:12:25 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15226809#comment-15226809
] 

Robert Muir commented on LUCENE-7179:
-------------------------------------

{quote}
If you're referring to TestEncodingUtils.testEncodeDecodeRoundsDown it passes fine with the
LUCENE-7164 64 bit space change.
{quote}

No I am not: that test is relatively worthless because it does not test, and *will never test*
the values that are buggy. If you fix it to look like LatLonPoint's, it will fail, and it
will fail with the new encoding on LUCENE-7164 too.

> GeoPoint and LatLonPoint test data should quantize once
> -------------------------------------------------------
>
>                 Key: LUCENE-7179
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7179
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Nicholas Knize
>         Attachments: LUCENE-7179.patch
>
>
> {{LatLonPoint}} and {{GeoPointField}} tests pre quantizes test data to ensure consistency
with indexed (encoded) data. The pre quantized data then becomes indexed, undergoing another
quantization. To guarantee numerical stability this should be changed such that the test data
is quantized after indexing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message