lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tomás Fernández Löbbe (JIRA) <j...@apache.org>
Subject [jira] [Updated] (SOLR-8873) Enforce dataDir/instanceDir/ulogDir to be paths that contain only a controlled subset of characters
Date Mon, 21 Mar 2016 17:35:25 GMT

     [ https://issues.apache.org/jira/browse/SOLR-8873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Tomás Fernández Löbbe updated SOLR-8873:
----------------------------------------
    Attachment: SOLR-8873.patch

Here is an initial proposal. Again, I'm not 100% sure that this will not break valid use cases,
probably the pattern needs to be expanded. 
For example, the pattern would not accept accented characters, and since this is checking
the absolute path, tests would not pass if your lucene-solr root is on an unsupported path

> Enforce dataDir/instanceDir/ulogDir to be paths that contain only a controlled subset
of characters
> ---------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-8873
>                 URL: https://issues.apache.org/jira/browse/SOLR-8873
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Tomás Fernández Löbbe
>         Attachments: SOLR-8873.patch
>
>
> We currently support any valid path for dataDir/instanceDir/ulogDir. I think we should
prevent special characters and restrict to a subset that is commonly used and tested.
> My initial proposals it to allow the Java pattern: {code:java}"^[a-zA-Z0-9\\.\\ \\\\\\-_/\"':]+$"{code}
but I'm open to suggestions. I'm not sure if there can be issues with HDFS paths (this pattern
does pass the tests we currently have), or some other use case I'm not considering.
> I also think our tests should use all those characters randomly. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message