lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Rowe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-8778) Deprecate CSVStrategy's setters, and make its pre-configured strategies immutable
Date Thu, 03 Mar 2016 15:48:18 GMT

    [ https://issues.apache.org/jira/browse/SOLR-8778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15177985#comment-15177985
] 

Steve Rowe commented on SOLR-8778:
----------------------------------

+1, after the 6.0 release.  I'll commit the patch for now.

> Deprecate CSVStrategy's setters, and make its pre-configured strategies immutable
> ---------------------------------------------------------------------------------
>
>                 Key: SOLR-8778
>                 URL: https://issues.apache.org/jira/browse/SOLR-8778
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Steve Rowe
>         Attachments: SOLR-8778.patch
>
>
> Removing some deprecated things in CSVStrategy (SOLR-8764) exposed a bug: it's possible
to redefine the public static {{CSVStrategy.\{DEFAULT,EXCEL,TDF}_STRATEGY}} strategies, simply
by calling their setters.
> Right now that's happening in {{CSVParserTest.testUnicodeEscape()}}, where the default
unicode escape interpretation is changed from false to true.  And then if that test happens
to run before {{CSVStrategyTest.testSetCSVStrategy()}}, which tests that the unicode escape
interpretation on the default strategy is set to false, then the latter will fail.
> Example failures: http://jenkins.thetaphi.de/job/Lucene-Solr-trunk-Linux/16079/ and http://jenkins.thetaphi.de/job/Lucene-Solr-trunk-MacOSX/3126/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message