lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <>
Subject [jira] [Commented] (SOLR-8778) Deprecate CSVStrategy's setters, and make its pre-configured strategies immutable
Date Thu, 03 Mar 2016 15:46:18 GMT


Uwe Schindler commented on SOLR-8778:

+1 to fix this!

Ideally we should remove our CSV fork from Solr's repository! I tried to do that and cut over
to the official release, but I gave up; see SOLR-3213. The commons-csv release is a total
rewrite not having any overlap with our early fork in the internal package. The official release
does not support most "hackish" stuff, introduced to spare allocations (which is no longer
an issue in Java 8, we can do {{new CSV*()}} as often as we like, Hotspot optimizes that away).
I think this stuff also is the reason for this issue, [~steve_rowe]?

So we should really upgrade to a better CSV parser (official commons-csv) and remove the "reuse"
of instances in thread unsafe ways.

> Deprecate CSVStrategy's setters, and make its pre-configured strategies immutable
> ---------------------------------------------------------------------------------
>                 Key: SOLR-8778
>                 URL:
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Steve Rowe
>         Attachments: SOLR-8778.patch
> Removing some deprecated things in CSVStrategy (SOLR-8764) exposed a bug: it's possible
to redefine the public static {{CSVStrategy.\{DEFAULT,EXCEL,TDF}_STRATEGY}} strategies, simply
by calling their setters.
> Right now that's happening in {{CSVParserTest.testUnicodeEscape()}}, where the default
unicode escape interpretation is changed from false to true.  And then if that test happens
to run before {{CSVStrategyTest.testSetCSVStrategy()}}, which tests that the unicode escape
interpretation on the default strategy is set to false, then the latter will fail.
> Example failures: and

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message