lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Gerlowski (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-8725) Cores, collections, and shards should accept hyphens in identifier name
Date Sat, 27 Feb 2016 15:32:18 GMT

    [ https://issues.apache.org/jira/browse/SOLR-8725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15170622#comment-15170622
] 

Jason Gerlowski commented on SOLR-8725:
---------------------------------------

Hey [~anshumg], were you planning on changing the messages that get returned from the core/collection/shard
APIs when an invalid identifier is used?  I think they mention specifically what characters
are allowed in a valid identifier.  If the regex is changing, the messages should probably
be updated also.  (Might make sense to pull the message into a single constant that lives
in {{SolrIdentifierValidator}} too, but maybe it doesn't, I'd have to look.)

Happy to update the patch myself with those changes if you want.  Wanted to check first though;
didn't want to step on your toes if there's a reason you didn't do it.

> Cores, collections, and shards should accept hyphens in identifier name
> -----------------------------------------------------------------------
>
>                 Key: SOLR-8725
>                 URL: https://issues.apache.org/jira/browse/SOLR-8725
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 5.5
>            Reporter: Chris Beer
>            Assignee: Anshum Gupta
>         Attachments: SOLR-8725.patch
>
>
> In SOLR-8642, hyphens are no longer considered valid identifiers for cores (and collections?).
Our solr instance was successfully using hyphens in our core names, and our affected cores
now error with:
> marc-profiler_shard1_replica1: org.apache.solr.common.SolrException:org.apache.solr.common.SolrException:
Invalid name: 'marc-profiler_shard1_replica1' Identifiers must consist entirely of periods,
underscores and alphanumerics
> Before starting to rename all of our collections, I wonder if this decision could be
revisited to be backwards compatible with previously created collections.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message