lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anshum Gupta (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-7012) Change eclipse's "New Java Files" template to place the license header before the package declaration
Date Wed, 03 Feb 2016 17:11:39 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-7012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15130699#comment-15130699
] 

Anshum Gupta commented on LUCENE-7012:
--------------------------------------

Thanks Shai. LGTM, would be good to have this for idea too though :). I haven't really played
around with that but I can try.
In the meanwhile, I think we should at least get it in for eclipse.

About the existing files, it would be good to have this fixed everywhere, though not sure
if it's worth the time. We should be able to get this fixed as and when we touch those files
but if anyone has a quick way to fix it, it'd be great.

> Change eclipse's "New Java Files" template to place the license header before the package
declaration
> -----------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-7012
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7012
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Shai Erera
>            Assignee: Shai Erera
>         Attachments: LUCENE-7012.patch
>
>
> Today the license header is placed after the package declaration. This results in inconsistency
in our files. In some the license is put after the package and before the imports, in others
it appears after the imports but before class declaration and in others it appears in the
middle of the imports.
> Also, when you e.g. "Organize Imports" in eclipse, if the header is located in the middle
of imports, it's sometimes completely removed from the file.
> This issue is about changing the "New Java Files" template in eclipse so that the license
header is placed before the package declaration. This ensures that "Organize Imports" doesn't
mess with it, as well for new files (created in eclipse), we will start getting some consistency.
> If we also want to handle all current files by moving the license header before the package,
we can do so (I volunteer), but since it's a big change, will likely do it over multiple commits
and no need for an issue. BTW, if anyone knows of a tool that can automate that, great. I
found that Apache has a perl script but it seems to only fix the header to the new format,
yet not moving it in the file.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message