lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-6998) We should detect truncation for all index files
Date Wed, 10 Feb 2016 16:28:19 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-6998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15141095#comment-15141095
] 

ASF subversion and git services commented on LUCENE-6998:
---------------------------------------------------------

Commit df30bc6c5b4855fcd95c3660fdd2991d0e9c58bf in lucene-solr's branch refs/heads/branch_5_4
from Mike McCandless
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=df30bc6 ]

LUCENE-6998: fix a couple places to better detect truncated index files; improve corruption
testing

Conflicts:
	lucene/core/src/java/org/apache/lucene/codecs/lucene60/Lucene60PointFormat.java
	lucene/core/src/java/org/apache/lucene/codecs/lucene60/Lucene60PointReader.java
	lucene/core/src/java/org/apache/lucene/codecs/lucene60/Lucene60PointWriter.java

Conflicts:
	lucene/CHANGES.txt


> We should detect truncation for all index files
> -----------------------------------------------
>
>                 Key: LUCENE-6998
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6998
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: 5.5, master, 6.0, 5.4.2
>
>         Attachments: LUCENE-6998.patch, LUCENE-6998.patch, LUCENE-6998.patch
>
>
> [~rcmuir] noticed that {{Lucene60PointReader}} does not detect truncation of its data
file on reader init ... so I added a test to catch this, confirmed it caught the bug, and
fixed the bug, and fixed a couple other things uncovered by the test.
> I also improved the other {{TestAllFiles*}} tests to use {{LineFileDocs}} so they index
points, and it caught another bug in {{Lucene60PointFormat}} (using the same codec name in
two files).
> There is more to do here, e.g. we also need a test that catches places where we fail
to check the index header on init, which was also missing for {{Lucene60PointReader}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message