lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christine Poerschke (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-5730) make Lucene's SortingMergePolicy and EarlyTerminatingSortingCollector configurable in Solr
Date Thu, 11 Feb 2016 13:24:18 GMT

    [ https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15142711#comment-15142711
] 

Christine Poerschke commented on SOLR-5730:
-------------------------------------------

Thanks for the review comments [~shaie]!

bq. ... I wonder if we can have a protected abstract getMergePolicyInstance(wrappedMP) ...

Yes, that makes sense and will make {{WrapperMergePolicyFactory}} similar to {{WrapperMergePolicyFactory}}
i.e. both will have a {{protected abstract MergePolicy getMergePolicyInstance}} though with
different arguments. Will action this under SOLR-8621 where it really belongs.

bq. {{RandomForceMergePolicyFactory}} is not really related to this issue. Perhaps you should
commit it separately?

Yes, I agree, since {{RandomForceMergePolicy}} already exists this would belong to SOLR-8621
also.

> make Lucene's SortingMergePolicy and EarlyTerminatingSortingCollector configurable in
Solr
> ------------------------------------------------------------------------------------------
>
>                 Key: SOLR-5730
>                 URL: https://issues.apache.org/jira/browse/SOLR-5730
>             Project: Solr
>          Issue Type: New Feature
>            Reporter: Christine Poerschke
>            Assignee: Christine Poerschke
>            Priority: Minor
>              Labels: blocker
>             Fix For: 5.5, master
>
>         Attachments: SOLR-5730-part1and2.patch, SOLR-5730-part1of2.patch, SOLR-5730-part1of2.patch,
SOLR-5730-part2of2.patch, SOLR-5730-part2of2.patch
>
>
> *Example configuration (solrconfig.xml) :*
> {noformat}
> -<mergePolicy class="TieredMergePolicy"/>
> +<mergePolicyFactory class="org.apache.solr.index.SortingMergePolicyFactory">
> +  <str name="wrapped.prefix">in</str>
> +  <str name="in.class">org.apache.solr.index.TieredMergePolicyFactory</str>
> +  <str name="sort">timestamp desc</str>
> +</mergePolicyFactory>
> {noformat}
> *Example use (EarlyTerminatingSortingCollector):*
> {noformat}
> &sort=timestamp+desc&segmentTerminateEarly=true
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message