lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yonik Seeley (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-8453) Jetty update from 9.2 to 9.3 causes the server to reset formerly legitimate client connections.
Date Thu, 07 Jan 2016 15:32:39 GMT

    [ https://issues.apache.org/jira/browse/SOLR-8453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15087580#comment-15087580
] 

Yonik Seeley commented on SOLR-8453:
------------------------------------

Nice find!

I've been messing around on the client side with HttpURLConnection and raw sockets.

Even with HttpURLConnection (the stuff built into the JVM) I can't even get the status code...
The server has probably written the error response, but the client side wants to push the
complete request before looking at it I guess:

{code}
Caused by: java.io.IOException: Error writing to server
	at sun.net.www.protocol.http.HttpURLConnection.writeRequests(HttpURLConnection.java:665)
	at sun.net.www.protocol.http.HttpURLConnection.writeRequests(HttpURLConnection.java:677)
	at sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1533)
	at sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1440)
	at java.net.HttpURLConnection.getResponseCode(HttpURLConnection.java:480)
	at org.apache.solr.client.solrj.TestSolrJErrorHandling.testHttpURLConnection(TestSolrJErrorHandling.java:242)
{code}
Catching the exception and trying to get the errorStream also doesn't work.

Anyway, I had a thought that even if we could fix this in the SolrJ clients, there are a lot
of other clients out there that will get bitten by this.
Regardless of what improvements we make to SolrJ, it seems like we should roll back the Jetty
upgrade.


> Jetty update from 9.2 to 9.3 causes the server to reset formerly legitimate client connections.
> -----------------------------------------------------------------------------------------------
>
>                 Key: SOLR-8453
>                 URL: https://issues.apache.org/jira/browse/SOLR-8453
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>         Attachments: SOLR-8453.patch, SOLR-8453.patch, SOLR-8453.patch, SOLR-8453.patch,
SOLR-8453.patch, SOLR-8453.patch, SOLR-8453.patch, SOLR-8453_test.patch, SOLR-8453_test.patch
>
>
> The basic problem is that when we are streaming in updates via a client, an update can
fail in a way that further updates in the request will not be processed, but not in a way
that causes the client to stop and finish up the request before the server does something
else with that connection.
> This seems to mean that even after the server stops processing the request, the concurrent
update client is still in the process of sending the request. It seems previously, Jetty would
not go after the connection very quickly after the server processing thread was stopped via
exception, and the client (usually?) had time to clean up properly. But after the Jetty upgrade
from 9.2 to 9.3, Jetty closes the connection on the server sooner than previous versions (?),
and the client does not end up getting notified of the original exception at all and instead
hits a connection reset exception. The result was random fails due to connection reset throughout
our tests and one particular test failing consistently. Even before this update, it does not
seem like we are acting in a safe or 'behaved' manner, but our version of Jetty was relaxed
enough (or a bug was fixed?) for our tests to work out.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message