lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael McCandless <luc...@mikemccandless.com>
Subject Re: lucene-solr git commit: make this test less anal about scores so the new DFI sim won't cause false failures
Date Sat, 23 Jan 2016 15:29:24 GMT
Woops, thanks Uwe!

Mike McCandless

http://blog.mikemccandless.com


On Sat, Jan 23, 2016 at 9:51 AM, Uwe Schindler <uwe@thetaphi.de> wrote:
> Hi Mike,
>
> the GIT Howto page at apache says, that your commits should use the @apache.org address.
If you don't want to change this globally, you can set the e-mail address for a working-copy
only, see second one:
>
> https://git-wip-us.apache.org/#committers-getting-started
>
> Your current commit makes it look like you (mikemccand@apache.org) pushed a commit from
somebody else (mail@mikemccandless.com).
>
> Uwe
>
> -----
> Uwe Schindler
> H.-H.-Meier-Allee 63, D-28213 Bremen
> http://www.thetaphi.de
> eMail: uwe@thetaphi.de
>
>> -----Original Message-----
>> From: mikemccand@apache.org [mailto:mikemccand@apache.org]
>> Sent: Saturday, January 23, 2016 3:32 PM
>> To: commits@lucene.apache.org
>> Subject: lucene-solr git commit: make this test less anal about scores so the
>> new DFI sim won't cause false failures
>>
>> Repository: lucene-solr
>> Updated Branches:
>>   refs/heads/master 657b3e617 -> 1199bbe1b
>>
>>
>> make this test less anal about scores so the new DFI sim won't cause false
>> failures
>>
>>
>> Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
>> Commit: http://git-wip-us.apache.org/repos/asf/lucene-
>> solr/commit/1199bbe1
>> Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/1199bbe1
>> Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/1199bbe1
>>
>> Branch: refs/heads/master
>> Commit: 1199bbe1b39e73c6e78ec570eae2ae62a5ccc361
>> Parents: 657b3e6
>> Author: Michael McCandless <mail@mikemccandless.com>
>> Authored: Sat Jan 23 09:31:39 2016 -0500
>> Committer: Mike McCandless <mikemccand@apache.org>
>> Committed: Sat Jan 23 09:31:39 2016 -0500
>>
>> ----------------------------------------------------------------------
>>  .../src/test/org/apache/lucene/search/grouping/TestGrouping.java | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>> ----------------------------------------------------------------------
>>
>>
>> http://git-wip-us.apache.org/repos/asf/lucene-
>> solr/blob/1199bbe1/lucene/grouping/src/test/org/apache/lucene/search/gr
>> ouping/TestGrouping.java
>> ----------------------------------------------------------------------
>> diff --git
>> a/lucene/grouping/src/test/org/apache/lucene/search/grouping/TestGroupi
>> ng.java
>> b/lucene/grouping/src/test/org/apache/lucene/search/grouping/TestGroup
>> ing.java
>> index a8711c5..2842528 100644
>> ---
>> a/lucene/grouping/src/test/org/apache/lucene/search/grouping/TestGroupi
>> ng.java
>> +++
>> b/lucene/grouping/src/test/org/apache/lucene/search/grouping/TestGroup
>> ing.java
>> @@ -176,8 +176,8 @@ public class TestGrouping extends LuceneTestCase {
>>      assertEquals(0, group.scoreDocs[0].doc);
>>      assertEquals(1, group.scoreDocs[1].doc);
>>      assertEquals(2, group.scoreDocs[2].doc);
>> -    assertTrue(group.scoreDocs[0].score > group.scoreDocs[1].score);
>> -    assertTrue(group.scoreDocs[1].score > group.scoreDocs[2].score);
>> +    assertTrue(group.scoreDocs[0].score >= group.scoreDocs[1].score);
>> +    assertTrue(group.scoreDocs[1].score >= group.scoreDocs[2].score);
>>
>>      group = groups.groups[2];
>>      compareGroupValue("author2", group);
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message