Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@lucene.apache.org
Date: Tue, 22 Dec 2015 14:08:46 +0000 (UTC)
From: "Shai Erera (JIRA)" <jira@apache.org>
To: dev@lucene.apache.org
Message-ID: <JIRA.12923753.1450793266000.93105.1450793326611@Atlassian.JIRA>
In-Reply-To: <JIRA.12923753.1450793266000@Atlassian.JIRA>
References: <JIRA.12923753.1450793266000@Atlassian.JIRA>
 <JIRA.12923753.1450793266956@arcas>
Subject: [jira] [Created] (SOLR-8455) Minor improvements to RecoveryStrategy
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

Shai Erera created SOLR-8455:
--------------------------------

             Summary: Minor improvements to RecoveryStrategy
                 Key: SOLR-8455
                 URL: https://issues.apache.org/jira/browse/SOLR-8455
             Project: Solr
          Issue Type: Improvement
          Components: SolrCloud
            Reporter: Shai Erera
            Assignee: Shai Erera
            Priority: Minor
             Fix For: 5.5, Trunk
         Attachments: SOLR-8455.patch

This issue addresses multiple minor improvements to {{RecoveryStrategy}}:

* Logging improvements: proper use of Logger interface, improve log messages.
* Consolidated a debug block into a method and reuse.
* Get rid of unused and deprecated code.

In addition, the code over-slept between recovery attempts. The inline comment suggested that the intention was to sleep between 1 second to 1 minute, while implement an exponential sleep interval strategy. However in practice the code sleeps in intervals of 5 seconds and up to 5 minutes. So I fixed the code to sleep at interval of 5 seconds (checking if it was closed in between sleep attempts) and up to 1 minute.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org