Return-Path: X-Original-To: apmail-lucene-dev-archive@www.apache.org Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3CE4C18EB4 for ; Mon, 21 Dec 2015 17:30:48 +0000 (UTC) Received: (qmail 10576 invoked by uid 500); 21 Dec 2015 17:30:47 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 10434 invoked by uid 500); 21 Dec 2015 17:30:47 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 10316 invoked by uid 99); 21 Dec 2015 17:30:46 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 21 Dec 2015 17:30:46 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id A59F32C1F54 for ; Mon, 21 Dec 2015 17:30:46 +0000 (UTC) Date: Mon, 21 Dec 2015 17:30:46 +0000 (UTC) From: "Mark Miller (JIRA)" To: dev@lucene.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (SOLR-8451) We should be calling method.abort before response.close in HttpSolrClient MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SOLR-8451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15066748#comment-15066748 ] Mark Miller commented on SOLR-8451: ----------------------------------- {noformat} Index: solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrClient.java =================================================================== --- solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrClient.java (revision 1720969) +++ solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrClient.java (working copy) @@ -589,14 +589,16 @@ throw new SolrServerException( "IOException occured when talking to server at: " + getBaseURL(), e); } finally { - if (respBody != null && shouldClose) { - try { - respBody.close(); - } catch (IOException e) { - log.error("", e); - } finally { - if (!success) { - method.abort(); + try { + if (!success) { + method.abort(); + } + } finally { + if (respBody != null && shouldClose) { + try { + respBody.close(); + } catch (IOException e) { + log.error("", e); } } } {noformat} > We should be calling method.abort before response.close in HttpSolrClient > ------------------------------------------------------------------------- > > Key: SOLR-8451 > URL: https://issues.apache.org/jira/browse/SOLR-8451 > Project: Solr > Issue Type: Bug > Reporter: Mark Miller > -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org