Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@lucene.apache.org
Date: Wed, 16 Dec 2015 17:59:46 +0000 (UTC)
From: "Mark Miller (JIRA)" <jira@apache.org>
To: dev@lucene.apache.org
Message-ID: <JIRA.12921802.1450132471000.42216.1450288786958@Atlassian.JIRA>
In-Reply-To: <JIRA.12921802.1450132471000@Atlassian.JIRA>
References: <JIRA.12921802.1450132471000@Atlassian.JIRA>
 <JIRA.12921802.1450132471218@arcas>
Subject: [jira] [Commented] (SOLR-8416) Solr collection creation API should
 return after all cores are alive
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/SOLR-8416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15060419#comment-15060419 ] 

Mark Miller commented on SOLR-8416:
-----------------------------------

Thanks for the patch, a couple comments:

* Usually it's better to use SolrException over RuntimeException
* Where you catch the interrupted exception, you should restore the interrupted status.
* The failure exception should probably give detail on which replicas were not found to be live and ACTIVE.
* Should not use hard coded 'active' but the relevant constants.
* Should probably check if the replicas node is listed under live nodes as well as if it's active?

> Solr collection creation API should return after all cores are alive 
> ---------------------------------------------------------------------
>
>                 Key: SOLR-8416
>                 URL: https://issues.apache.org/jira/browse/SOLR-8416
>             Project: Solr
>          Issue Type: Bug
>          Components: SolrCloud
>            Reporter: Michael Sun
>         Attachments: SOLR-8416.patch
>
>
> Currently the collection creation API returns once all cores are created. In large cluster the cores may not be alive for some period of time after cores are created. For any thing requested during that period, Solr appears unstable and can return failure. Therefore it's better  the collection creation API waits for all cores to become alive and returns after that.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org